[ 
https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244972#comment-15244972
 ] 

ASF GitHub Bot commented on THRIFT-71:
--------------------------------------

Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/988#discussion_r59995093
  
    --- Diff: debian/rules ---
    @@ -199,8 +199,8 @@ binary-common:
        dh_installexamples
        dh_installman
        dh_link
    -   dh_strip -ppython-thrift --dbg=python-thrift-dbg
    -   dh_strip -ppython3-thrift --dbg=python3-thrift-dbg
    +   dh_strip -ppython-thrift --dbg-package=python-thrift-dbg
    +   dh_strip -ppython3-thrift --dbg-package=python3-thrift-dbg
    --- End diff --
    
    Actually, -dbg= was from original line from THRIFT-71.
    I don't know much about this but seeing the doc it seems this fix seems 
correct.


> Debian packaging for thrift
> ---------------------------
>
>                 Key: THRIFT-71
>                 URL: https://issues.apache.org/jira/browse/THRIFT-71
>             Project: Thrift
>          Issue Type: Improvement
>         Environment: debian stable (etch); probably will work on lenny, but 
> untested
>            Reporter: Eric Anderson
>            Assignee: Roger Meier
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: THRIFT-71_v10.1.patch, THRIFT-71_v10.2.patch, 
> THRIFT-71_v10.patch, THRIFT-71_v8_0.5.0.patch, THRIFT-71_v9.patch, 
> debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, 
> thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, 
> thrift-71_v6.patch, thrift-71_v7.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release.  It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests.  If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to