GitHub user jamesreggio opened a pull request:
https://github.com/apache/thrift/pull/989
THRIFT-3789 Add `destroy` to Connection instance
This commit proxies the `destroy` method from the Thrift Connection object
to its underlying socket, akin to the existing `end` method.
Without `destroy`, it's possible for a failed TLS socket to hold the
Node.js process open. (Calling `end` is not sufficient to close the OS handle
because `end` sends a `FIN` packet, which is never acknowledged by the server.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jamesreggio/thrift THRIFT-3789
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/989.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #989
----
commit b2907fd207736ec95f37919528f6dc6990f007c8
Author: James Reggio <[email protected]>
Date: 2016-04-18T19:49:50Z
THRIFT-3789 Add `destroy` to Connection instance
This commit proxies the `destroy` method from the Thrift Connection
object to its underlying socket, akin to the existing `end` method.
Without `destroy`, it's possible for a failed TLS socket to hold the
Node.js process open. (Calling `end` is not sufficient to close the OS
handle because `end` sends a FIN packet, which is never acknowledged by
the server.)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
