[
https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248723#comment-15248723
]
Jens Geyer commented on THRIFT-3791:
------------------------------------
No critsects, not necessary. Use interlocked if you need, it's only a handle.
> Delphi pipe client may fail even in a non-error condition
> ---------------------------------------------------------
>
> Key: THRIFT-3791
> URL: https://issues.apache.org/jira/browse/THRIFT-3791
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
> Affects Versions: 1.0
> Reporter: Kyle Johnson
> Assignee: Jens Geyer
> Fix For: 0.10.0
>
> Attachments:
> 0001-THRIFT-3791-Delphi-pipe-client-may-fail-even-in-a-no.patch,
> THRIFT-3791-fix-for-calling-GetLastError-even-on-success.patch
>
>
> In TPipeStreamBase.ReadDirect(), the code performs a peek on the pipe. If no
> data is available (bytes = 0), GetLastError is still checked, even though
> Microsoft documentation clearly states that not all functions set the last
> error code to 0 on success
> (https://msdn.microsoft.com/en-us/library/windows/desktop/ms679360(v=vs.85).aspx).
> Furthermore, because PeekNamedPipe only mentions that GetLastError should
> be called on failure, the logic of the if test must be changed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
