GitHub user bgould opened a pull request:

    https://github.com/apache/thrift/pull/996

    THRIFT-3803 - Tweak attributes that are exported from XML generator

    When I created the XML generator, I added an attribute named "file" to the 
<include /> element that has path information to the included file.
    
    However, the information being exported into the XML file however is an 
absolute path that is specific to the system on which the XML file is 
generated, which probably should not exported. Additionally, I'm not sure that 
the path information has much particular use anyhow, so IMO this should just be 
removed (especially since it has not been in an official release yet).
    
    Also, when running the tests for this I noticed some attributes in the XSD 
were not properly specified as required, so I added that information to XSD.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bgould/thrift THRIFT-3803

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/996.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #996
    
----
commit 4b2d209c4d2f9be947261186b7d668d7e7595c4d
Author: BCG <bgo...@users.noreply.github.com>
Date:   2016-04-28T14:54:13Z

    THRIFT-3803 - Remove file attribute from include elements in XML generator

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to