[ 
https://issues.apache.org/jira/browse/THRIFT-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263754#comment-15263754
 ] 

ASF GitHub Bot commented on THRIFT-3806:
----------------------------------------

GitHub user stigsb opened a pull request:

    https://github.com/apache/thrift/pull/997

    Make generated structs "final class" to make self-referencing possible

    See [THRIFT-3806](https://issues.apache.org/jira/browse/THRIFT-3806)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stigsb/thrift swift_final_class

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/997.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #997
    
----
commit 5004ce598f551e13c9a19ec932e066dfa5b002d2
Author: Stig Bakken <s...@zedge.net>
Date:   2016-04-06T14:35:37Z

    Make generated structs "final class" to make self-referencing possible

----


> Swift generator does not handle self-referring structs
> ------------------------------------------------------
>
>                 Key: THRIFT-3806
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3806
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Stig Bakken
>            Priority: Minor
>
> Changing generated code from `struct` to `final class` solves this. Haven't 
> found any other problems with this approach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to