[
https://issues.apache.org/jira/browse/THRIFT-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307908#comment-15307908
]
ASF GitHub Bot commented on THRIFT-3844:
----------------------------------------
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1021
Fix THRIFT-3844
update `php_thrift_protocol7.cpp`
let `php_thrift_protocol` can compiled with php7.0.7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift THRIFT-3844
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1021.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1021
----
commit fd909b86adb1841f97b961a3dc19a15c818ee85c
Author: visoeclipse <[email protected]>
Date: 2016-03-28T08:53:37Z
Update php_thrift_protocol7.cpp
bug fix
----
> thrift_protocol cannot compile in 7.0.7
> ---------------------------------------
>
> Key: THRIFT-3844
> URL: https://issues.apache.org/jira/browse/THRIFT-3844
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 1.0
> Environment: PHP 7.0.7, x86-64, OS-X 10.11
> Reporter: Robert Lu
>
> When compile thrift_protocol extension with php7.0.7 in OS X 10.11,
> Report error:
> php_thrift_protocol7.cpp:290:27: error: no member named 'min' in namespace
> 'std'; did you mean 'fmin'?
> and
> zend_hash.h:168:30: note: candidate function not viable: no known conversion
> from 'unsigned long *' to 'zend_ulong *' (aka 'unsigned long long *') for 3rd
> argument
> ZEND_API int ZEND_FASTCALL zend_hash_get_current_key_ex(const HashTable
> *ht, zend_string **str_index, zend_ulong *num_index, HashPosition *pos);
> *And I find someone in github solved this problom, but no one notice it, so I
> create this issue*
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
