[
https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328447#comment-15328447
]
ASF GitHub Bot commented on THRIFT-3834:
----------------------------------------
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1027
THRIFT-3834 Erlang namespacing and exception metadata
Client: Erlang
Patch: Steve Cohen <[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-3834
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1027.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1027
----
commit e229a5c72eeb7e25b55aa1e4672316bcbe564e3e
Author: Steve Cohen <[email protected]>
Date: 2016-06-13T22:32:48Z
THRIFT-3834 Erlang namespacing and exception metadata
Client: Erlang
Patch: Steve Cohen <[email protected]>
----
> Erlang namespacing and exception metadata
> -----------------------------------------
>
> Key: THRIFT-3834
> URL: https://issues.apache.org/jira/browse/THRIFT-3834
> Project: Thrift
> Issue Type: New Feature
> Components: Erlang - Compiler
> Reporter: Steve Cohen
> Assignee: Steve Cohen
> Fix For: 0.10.0
>
> Attachments: thrift-3834-erlang_metadata_fixed_test_cross.patch
>
>
> The erlang modules generated by thrift cannot be namespaced, this change
> allows namespacing like in other thrift types.
> If Module A defines a struct S and Module B defines a struct S and Module A
> includes Module B, it will not compile. This change fixes that problem.
> If at all possible, I'd like this to get into 0.10
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
