[
https://issues.apache.org/jira/browse/THRIFT-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330199#comment-15330199
]
Jens Geyer commented on THRIFT-3853:
------------------------------------
Hi [~mjo],
thanks for the patch.
(1) IIRC this can be done with the [C++ anon
pipes|https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/transport/TPipe.h]
as well. What are advantages of your new transport over the existing? I'm not
saying that either solution is better or worse, I'm just asking.
(2) The "Copyright 2016 ICT-Project Mariusz Ornowski" is not part of the
standard ASF header and needs to be removed. You may want to consider the [ASF
license contribution
section|http://www.apache.org/licenses/LICENSE-2.0.html#contributions] again
and decide whether or not this is in conflict with your legal requirements.
> Transport to a child process established ad hoc (using stdin/stdout).
> ---------------------------------------------------------------------
>
> Key: THRIFT-3853
> URL: https://issues.apache.org/jira/browse/THRIFT-3853
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Reporter: Mariusz Ornowski
> Priority: Minor
> Attachments: thrift-3853-lib-cpp-child-process-transport.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
