[ https://issues.apache.org/jira/browse/THRIFT-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335331#comment-15335331 ]
James E. King, III commented on THRIFT-3831: -------------------------------------------- I'd recommend you open a pull request for this. The easiest way is generate a pull request from a fork of the thrift project on Github. That process and the patch upload method to contributing fixes can be found here: https://github.com/apache/thrift/blob/master/doc/committers.md. > build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with > unsigned char due to narrowing conversions > ---------------------------------------------------------------------------------------------------------------------- > > Key: THRIFT-3831 > URL: https://issues.apache.org/jira/browse/THRIFT-3831 > Project: Thrift > Issue Type: Bug > Reporter: Cody Schafer > Attachments: 0001-test-cpp-explicitly-use-signed-char.patch > > > Specifically, we get a bunch of errors like: > test/cpp/src/TestClient.cpp:404:15: error: narrowing conversion > of '-1' from 'int' to 'char' inside { } [-Wnarrowing] > gcc faq talks about this: https://gcc.gnu.org/wiki/FAQ#Wnarrowing > I've only seen this in gcc-6, but the faq seems to indicate it could occur in > gcc-5 as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)