[ 
https://issues.apache.org/jira/browse/THRIFT-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338408#comment-15338408
 ] 

ASF GitHub Bot commented on THRIFT-3812:
----------------------------------------

Github user apocolipse commented on the issue:

    https://github.com/apache/thrift/pull/1002
  
    So for Cocoapods/Carthage, you're also using Frameworks (startup time is 
negligible).  I'd almost recommend manually handling separate Podspec's to keep 
things Module scope namespaced, it doesn't seem right at this point to have 
Thrift generate Carthage/Cocoapods configurations.  SPM should be good enough 
when Swift 3.0 is stable to where it can point to specific files for modules, 
additionally Foundation is ready for server side use then as well so perhaps 
SPM is the way to go.
    
    Either way I wouldn't recommend this as a 1st-class feature for Swift code 
generation from Thrift.  Perhaps as an option "Use Obj-C Cocoa Namespacing", so 
that its explicitly clear that this isn't a Swift convention, but an old 
Obj-C/Cocoa convention.


> Option to prefix namespace to Swift type names
> ----------------------------------------------
>
>                 Key: THRIFT-3812
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3812
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Swift - Compiler
>            Reporter: HÃ¥kon Hitland
>            Priority: Minor
>
> Swift does have a way to namespace things within a pod, which can lead to 
> name collisions.
> This adds an option "swift:prefix_namespace" that will add Cocoa-style 
> prefixes to the generated code if the file has a defined Swift namespace.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to