[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344427#comment-15344427 ]
Chris Bannister commented on THRIFT-3799: ----------------------------------------- I would say this is not a good idea, and is not idiomatic Go. Using iota is for when the value does not matter, but in the case of thrift the value does matter so iota should not be used. It does not effect the code but makes it clear that the value of the enum is a specific value. > Make constants to use iota > -------------------------- > > Key: THRIFT-3799 > URL: https://issues.apache.org/jira/browse/THRIFT-3799 > Project: Thrift > Issue Type: Improvement > Components: Go - Library > Reporter: Mahendran Kathirvel > Priority: Minor > Labels: easyfix > Original Estimate: 24h > Remaining Estimate: 24h > > Now, the constants and enumerations are using hardcoded values but Go has a > elegant way of doing this by using `Iota` -- This message was sent by Atlassian JIRA (v6.3.4#6332)