Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1033#discussion_r68088614
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -284,7 +284,7 @@ void TServerSocket::listen() {
hints.ai_family = PF_UNSPEC;
hints.ai_socktype = SOCK_STREAM;
hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
- sprintf(port, "%d", port_);
+ snprintf(port, sizeof("65535"), "%d", port_);
--- End diff --
I think the allocation of the buffer for port is just as bizarre, but I
wanted to remain consistent. Let's see if the build passes; if it fails and I
need to rebase on master to kick another because of a transient issue, I can
make the changes you suggest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
