GitHub user thomas07vt opened a pull request:
https://github.com/apache/thrift/pull/1046
Ruby: Ensure that HTTP failures will clear the http transport outbuf var
With the current implementation, any Net HTTP failure will raise from the
#flush() method without resetting the @outbuf variable.
I think that resetting the @outbuf on these failures is more "expected"
behaviour. Especially if there is a malformed request that the downstream
server does not want to/can't handle. As far as I can tell, there is not way to
clear the @outbuf var apart from the #flush() method, so if that fails, then
you will just keep appending requests to the out buffer.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thomas07vt/thrift
RubyLib-Reset_outbuf_on_http_failures
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1046.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1046
----
commit a4f74efef86413cd09c0a3c418740bc1632e430b
Author: John Thomas <thoma...@vt.edu>
Date: 2016-07-12T15:06:19Z
Ensuring that HTTP failures will clear the http transport outbuf variable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
