[
https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380754#comment-15380754
]
ASF GitHub Bot commented on THRIFT-3876:
----------------------------------------
Github user oprudkyi commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1045#discussion_r71065930
--- Diff: lib/haxe/src/org/apache/thrift/transport/TFileStream.hx ---
@@ -24,6 +24,9 @@ import haxe.io.BytesBuffer;
import haxe.io.Input;
import haxe.io.Output;
+#if js
+import js.node.Fs;
+#end
--- End diff --
as for me current implementation is better over scattering the same
functionality over different files
i.e. always visible 'original' implementation as well js part which just
reimplements original one in target depended way
> haxe js/nodejs client
> ---------------------
>
> Key: THRIFT-3876
> URL: https://issues.apache.org/jira/browse/THRIFT-3876
> Project: Thrift
> Issue Type: Improvement
> Components: Haxe - Library
> Reporter: Oleksii Prudkyi
> Assignee: Oleksii Prudkyi
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
