[ 
https://issues.apache.org/jira/browse/THRIFT-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390567#comment-15390567
 ] 

ASF GitHub Bot commented on THRIFT-3886:
----------------------------------------

GitHub user nsuke opened a pull request:

    https://github.com/apache/thrift/pull/1054

    THRIFT-3886 PHP cross test client returns 0 even when failing

    This only fixes tests for primitive values.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nsuke/thrift THRIFT-3886

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1054
    
----
commit af3b6441f3ab8694b5c8cff7d18a1ecc7e11794f
Author: Nobuaki Sukegawa <[email protected]>
Date:   2016-07-22T09:09:32Z

    THRIFT-3886 PHP cross test client returns 0 even when failing
    
    This only fixes tests for primitive values.

----


> PHP cross test client returns 0 even when failing
> -------------------------------------------------
>
>                 Key: THRIFT-3886
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3886
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library, Test Suite
>            Reporter: Aki Sukegawa
>
> PHP cross test client never fails on invalid values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to