[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390688#comment-15390688
]
Jens Geyer commented on THRIFT-3855:
------------------------------------
MOD: fix the blocked bug when call Stop() twice or more
When Stop() is called twice or more, and no new connection accepted from
AcceptLoop(), the Stop() will be blocked because the quit channel is full.
Use a flag to ensure the Stop() executed only once, and no block.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huaiyun/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1028.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1028
----
commit 24d16aaaf20c97a944d22551a8a5215d830546c0
Author: ZhiyuYin <yinzh...@xiaomi.com>
Date: 2016-06-16T09:28:42Z
MOD: fix the blocked bug when call the Stop() twice or more
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
> In the go simple server, if Stop() is called multiple times it hangs
> --------------------------------------------------------------------
>
> Key: THRIFT-3855
> URL: https://issues.apache.org/jira/browse/THRIFT-3855
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.9.3
> Reporter: James E. King, III
> Priority: Minor
>
> From the submitter huaiwan:
> {quote}
> huaiyun commented 18 hours ago
> When Stop() is called twice or more, and no new connection accepted from
> AcceptLoop(), the Stop() will be blocked because the quit channel is full.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
