[
https://issues.apache.org/jira/browse/THRIFT-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465133#comment-15465133
]
Juwon Kim commented on THRIFT-3915:
-----------------------------------
https://github.com/apache/thrift/pull/1010
Found this. Somebody already mentioned it. So, so happy haha.
Please please look over this, and if it is happy with you please mergeeeeee~
Thanks. appkr.
> PSR(PHP Standard Recommendation) Conformance Violation
> ------------------------------------------------------
>
> Key: THRIFT-3915
> URL: https://issues.apache.org/jira/browse/THRIFT-3915
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Affects Versions: 0.9.3
> Environment: Any
> Reporter: Juwon Kim
> Labels: build
> Fix For: 0.9.3
>
>
> Hi there? I'm a server guy in Korea, mainly focuses on PHP development. I'm
> leaving this issue to let you know that Thrift-generated code violates
> PSR(PHP Standard Recommendation). And I'm asking you to follow the PHP
> community rules.
> I started using Apache Thrift a couple of days ago, I found out that
> Thrift-generated code does not follow PSR-1. In a nutshell a PHP file should
> contain only one
> class(http://www.php-fig.org/psr/psr-1/#3-namespace-and-class-names), but
> Thrift-generated one has many.
> The problem is that Thrift-generated classes cannot be autoloadable through
> PSR-4 autoload standard(http://www.php-fig.org/psr/psr-4/#3-examples). The
> workaround is writing a home-made autoloading logic, or taking advantage of
> symbolic link like https://github.com/appkr/psr4-autoload-test/ . Which is
> not elegant anyway.
> So I would like you to study the voice of PHP users on the importance of PSR.
> I hope to see your opinion soon.
> Thanks,
> appkr.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
