[
https://issues.apache.org/jira/browse/THRIFT-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465368#comment-15465368
]
ASF GitHub Bot commented on THRIFT-3920:
----------------------------------------
Github user thomas07vt commented on the issue:
https://github.com/apache/thrift/pull/1048
@nsuke Just filed an issue:
https://issues.apache.org/jira/browse/THRIFT-3920
Please feel free to edit the issue(or tell me what should be edited) if I
have left out any necessary info since this is the first time I have opened an
issue on the Thrift Jira board.
> Ruby: Ensuring that HTTP failures will clear the http transport outbuf var
> --------------------------------------------------------------------------
>
> Key: THRIFT-3920
> URL: https://issues.apache.org/jira/browse/THRIFT-3920
> Project: Thrift
> Issue Type: Bug
> Components: Ruby - Library
> Affects Versions: 0.9.3
> Reporter: John
>
> PR: https://github.com/apache/thrift/pull/1048
> With the current implementation, any Net HTTP failure will raise from the
> #flush() method without resetting the @outbuf variable.
> I think that resetting the @outbuf on these failures is more "expected"
> behaviour. Especially if there is a malformed request that the downstream
> server does not want to/can't handle. As far as I can tell, there is not way
> to clear the @outbuf var apart from the #flush() method, so if that fails,
> then you will just keep appending requests to the out buffer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
