GitHub user jmesmon opened a pull request:
https://github.com/apache/thrift/pull/1085
THRIFT-3831 in test/cpp explicitly use `signed char`
`char`'s signed-ness is implimentation dependent, and in the case where
`char` was not signed, we previously recieved errors like
thrift/0.9.3-r0/git/test/cpp/src/TestClient.cpp:404:15: error:
narrowing conversion of '-127' from 'int' to 'char' inside { } [-Wnarrowing]
(This example from gcc-6 on arm)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesmon/thrift thrift-3831-use-signed-char
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1085
----
commit 353ab11c3402265b62d865a24427b53e75fe1c5f
Author: Cody P Schafer <d...@codyps.com>
Date: 2016-09-09T19:50:26Z
THRIFT-3831 in test/cpp explicitly use `signed char`
`char`'s signed-ness is implimentation dependent, and in the case where
`char` was not signed, we previously recieved errors like
thrift/0.9.3-r0/git/test/cpp/src/TestClient.cpp:404:15: error:
narrowing conversion of '-127' from 'int' to 'char' inside { } [-Wnarrowing]
(This example from gcc-6 on arm)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
