[ 
https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482960#comment-15482960
 ] 

ASF GitHub Bot commented on THRIFT-3773:
----------------------------------------

Github user fumoboy007 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1084#discussion_r78312854
  
    --- Diff: lib/swift/Sources/LinuxHelper.swift ---
    @@ -0,0 +1,42 @@
    +//
    +//  LinuxHelper.swift
    +//  Thrift
    +//
    +//  Created by Christopher Simpson on 8/22/16.
    +//
    +//
    +
    +import Foundation
    +import CoreFoundation
    +
    +#if os(Linux)
    +/// Extensions for Linux for incomplete Foundation API's.
    +/// swift-corelibs-foundation is not yet 1:1 with OSX/iOS Foundation
    +
    +extension URLSession {
    +  // Current one uses NSURLRequest which doesn't currently bridge
    +  @discardableResult
    +  open func dataTask(with request: URLRequest, completionHandler: 
@escaping (Data?, URLResponse?, Error?) -> Void) -> URLSessionDataTask {
    --- End diff --
    
    Not necessary anymore I think: 
https://github.com/apple/swift-corelibs-foundation/blob/master/Foundation/NSURLSession/NSURLSession.swift#L423


> Swift Library
> -------------
>
>                 Key: THRIFT-3773
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3773
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Swift - Library
>            Reporter: Thomas Bartelmess
>
> We already have the option to generate Swift code in the Cocoa compiler, 
> however large parts of the (Objective-C) Cocoa Library still depend on Cocoa 
> and  Objective-C.
> It would be good to have a native Swift library that doesn't depend on the 
> Cocoa libraries.
> Design goals:
> - Fully compatible with the code that is currently generated by the Cocoa 
> compiler (both Objective-C and Swift).
> - Ability to run on Linux
> - Pure Swift, no Objective-C code.
> - No dependencies on closed source apple libraries
> - Keep the same interface, so that the library is compatible with the code 
> the current cocoa compiler generates
> - Better server support that the current Objective-C library.
> - Follow the new Swift packaging format to be compatible with the Swift 
> Package manager



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to