[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

[fumoboy007]

Github user fumoboy007 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1084#discussion_r78313579
  
    --- Diff: lib/swift/Sources/LinuxHelper.swift ---
    @@ -0,0 +1,42 @@
    +//
    +//  LinuxHelper.swift
    +//  Thrift
    +//
    +//  Created by Christopher Simpson on 8/22/16.
    +//
    +//
    +
    +import Foundation
    +import CoreFoundation
    +
    +#if os(Linux)
    +/// Extensions for Linux for incomplete Foundation API's.
    +/// swift-corelibs-foundation is not yet 1:1 with OSX/iOS Foundation
    +
    +extension URLSession {
    +  // Current one uses NSURLRequest which doesn't currently bridge
    +  @discardableResult
    +  open func dataTask(with request: URLRequest, completionHandler: 
@escaping (Data?, URLResponse?, Error?) -> Void) -> URLSessionDataTask {
    --- End diff --
    
    I’m not too sure how the tagging/branching works in the Swift repo, but I 
see that the 
[commit](https://github.com/apple/swift-corelibs-foundation/commit/cffa65a1f933ddb29b7d3d21cd1756caeddc238f)
 is in `swift-3.0-branch` (as well as `master`) and is included in the 
`swift-3.0-GM-CANDIDATE` tag.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---