Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1022#discussion_r80386881
--- Diff: lib/php/lib/Thrift/Protocol/TBinaryProtocolAccelerated.php ---
@@ -62,4 +62,9 @@ public function isStrictWrite()
{
return $this->strictWrite_;
}
+
+ public function isBinaryAccelerated()
+ {
+ return true;
+ }
--- End diff --
I agree we need something like this but the name can be more general.
For example, `isAccelerated` or even `isDynamic`.
(Thinks about the day when we add TCompactProtocolAccelerated or anything
without generated read/write calls...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
