[ https://issues.apache.org/jira/browse/THRIFT-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533665#comment-15533665 ]
James E. King, III commented on THRIFT-3936: -------------------------------------------- This needs a code review - it passed the CI builds. This will fix VS2013 and earlier with 0.10.0 so want to get it in before we build the RC. > Cannot compile 0.10.0 development tip with VS2013 and earlier (snprintf, > uint32_t) > ---------------------------------------------------------------------------------- > > Key: THRIFT-3936 > URL: https://issues.apache.org/jira/browse/THRIFT-3936 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.10.0 > Environment: Visual Studio 2013, VS2013, Visual Studio 2010, VS2010, > Windows > Reporter: James E. King, III > Assignee: James E. King, III > Original Estimate: 0.25h > Time Spent: 1h > Remaining Estimate: 0h > > A change introduced in July changed some code that won't compile on VS2013: > https://github.com/apache/thrift/commit/e5176241c325837967a07d6d20e0e9a789fbd107 > snprintf is not available. > A pull request was submitted for this by someone in the community (thank > you!): > https://github.com/apache/thrift/pull/1096 > I recommended that the fix be done using PlatformSocket.h for abstraction of > the platform; I offered to submit a PR to do this. > In addition I found that with VS2010 I could not compile anything using > TApplicationException.h because uint32_t is used within it, but it doesn't > include stdlib.h. -- This message was sent by Atlassian JIRA (v6.3.4#6332)