[ https://issues.apache.org/jira/browse/THRIFT-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616247#comment-15616247 ]
ASF GitHub Bot commented on THRIFT-3953: ---------------------------------------- GitHub user tpcwang opened a pull request: https://github.com/apache/thrift/pull/1118 THRIFT-3953 TSSLSocket::close should handle exceptions from waitForEv… …ent because it is called by the destructor You can merge this pull request into a Git repository by running: $ git pull https://github.com/tpcwang/thrift THRIFT-3953 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1118.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1118 ---- commit 9915bf8a93e7bf544a035a375347826cb850e4e2 Author: tpcwang <tpc.w...@gmail.com> Date: 2016-10-28T15:03:40Z THRIFT-3953 TSSLSocket::close should handle exceptions from waitForEvent because it is called by the destructor ---- > TSSLSocket::close should handle exceptions from waitForEvent because it is > called by the destructor. > ---------------------------------------------------------------------------------------------------- > > Key: THRIFT-3953 > URL: https://issues.apache.org/jira/browse/THRIFT-3953 > Project: Thrift > Issue Type: Bug > Reporter: Ted Wang > Assignee: Ted Wang > > ~TSSLSocket calls TSSLSocket::close, which calls TSSLSocket::waitForEvent. > TSSLSocket::waitForEvent() throws an exception in some cases: > - Unexpected error > - InterruptListener has been written to > - poll() times out > TSSLSocket::close should log the error but not emit an exception, similar to > how it handles errors from SSL_shutdown. -- This message was sent by Atlassian JIRA (v6.3.4#6332)