[
https://issues.apache.org/jira/browse/THRIFT-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15634595#comment-15634595
]
ASF GitHub Bot commented on THRIFT-3958:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1123
THRIFT-3958: support RelWithDebInfo and static RTL on windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift defect/THRIFT-3958
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1123
----
commit c6b9a8fb2dd2259286849a311a1c1c5d7da2fbc7
Author: James E. King, III <[email protected]>
Date: 2016-11-03T23:00:40Z
THRIFT-3958: support RelWithDebInfo and static RTL on windows
----
> CMake WITH_MT option for windows static runtime linking does not support the
> cmake build type RelWithDebInfo
> ------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3958
> URL: https://issues.apache.org/jira/browse/THRIFT-3958
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler, C++ - Library
> Affects Versions: 0.9.3
> Environment: Visual Studio 2010, CMake 3.6
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Trivial
>
> There is code in DefinePlatformSpecifc.cmake (note the file name has a typo
> in it) that allows one to set -DWITH_MT=ON and that will force the build to
> use a static runtime link. This works for debug and release builds, but not
> for RelWithDebInfo builds because the list in the cmake file is incomplete.
> It would be nice to switch to the ucm.cmake tools to make this a bit easier,
> but to fix this just a couple lines need to be added to that define cmake.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
