[ https://issues.apache.org/jira/browse/THRIFT-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15639138#comment-15639138 ]
Jens Geyer commented on THRIFT-3959: ------------------------------------ >From a technical view ypou are probably right. Essentially that would lead to >Go not offering a TSimpleServer, or, even worse, to *intentionally remove* the >threaded behaviour to get a "real" TSimpleServer. OTOH channels are a core concept of the Go ecosystem, and artifically crippling the code just to satisfy the naming sounds a bit silly to me. Consequentially, we would probably only rename TSimpleServer to TThreadedServer and just not offering a TSimpleServer at all (and breaking some code on the way) because it does not make much sense with Go. In an OOP language I would just derive the one from the other, add a nice comment, and forget about it. Unfortunately,m we are talking about Go, where complicated things are simple and simple things are complicated. > Golang TSimpleServer Is More Of A TThreadedServer? > -------------------------------------------------- > > Key: THRIFT-3959 > URL: https://issues.apache.org/jira/browse/THRIFT-3959 > Project: Thrift > Issue Type: Bug > Reporter: Paul Brown > > The documentation says TSimpleServer is a "Simple singlethreaded server for > testing.", however the golang implementation looks it spawns a go routine to > process each request: > https://github.com/apache/thrift/blob/master/lib/go/thrift/simple_server.go#L134-L138 > Shouldn't it be renamed to TThreadedServer? -- This message was sent by Atlassian JIRA (v6.3.4#6332)