Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1125#discussion_r87498574 --- Diff: lib/cpp/src/thrift/server/TConnectedClient.cpp --- @@ -86,7 +86,8 @@ void TConnectedClient::run() { } catch (const TException& tex) { --- End diff -- Just wondering, is catching TException enough here or should we catch std::exception here instead?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---