[
https://issues.apache.org/jira/browse/THRIFT-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657119#comment-15657119
]
ASF GitHub Bot commented on THRIFT-3947:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1127
THRIFT-3947 use sockaddr_storage with getsockname for future transport
compatibility (ipv6)
There's also code in windows/SocketPair that uses sockaddr_in however that
code is using loopback so I see no need to change it. The rest of the codebase
already changed over to use sockaddr_storage at some point in the past. Only
this lua implementation was left...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift defect/THRIFT-3947
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1127
----
commit 544bd38fa3d396cab95bef6a65d36e444437e086
Author: James E. King, III <jim.k...@simplivity.com>
Date: 2016-11-11T04:29:56Z
THRIFT-3947 use sockaddr_storage with getsockname for future transport
compatibility (ipv6)
----
> sockaddr type isn't always large enough for the return of getsockname
> ---------------------------------------------------------------------
>
> Key: THRIFT-3947
> URL: https://issues.apache.org/jira/browse/THRIFT-3947
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> Based on a conversation in THRIFT-1944 this was still an issue mid-2015,
> moving it out to a separate ticket.
> [~ben.craig] said:
> {quote}
> sockaddr_storage is recommended data type for this. I think main case is ipv6
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
