Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r87931893
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -60,7 +60,7 @@
#endif // _WIN32
#endif
-#if defined(_WIN32) && (_WIN32_WINNT < 0x0600)
+#if defined(_WIN32) && (_WIN32_WINNT < 0x0600) && !defined(AI_ADDRCONFIG)
#define AI_ADDRCONFIG 0x0400
--- End diff --
You didn't break this, but this kind of thing is exactly what the platform
socket header is for. Defining constants that don't belong to us often leads
to trouble. Instead, we should be defining something like THRIFT_AI_ADDRCONFIG
that can either be the real AI_ADDRCONFIG or 0x0400.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
