[
https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15667255#comment-15667255
]
James E. King, III commented on THRIFT-3828:
--------------------------------------------
I read in the the links you posted:
{quote}
The list of directories to remove is defined on the CMakes variables
CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES and CMAKE_C_IMPLICIT_INCLUDE_DIRECTORIES.
{quote}
This leads me to believe that anyone doing cross-compiling with gcc-6 can set
these and work around the problem without changing thrift CMake files. In
addition, it was suggested that cmake should be seeding this properly for gcc-6
automatically so this may be an issue with cmake that they will take care of in
an upcoming release, and not something we need to take any action on.
Thoughts? If that's the case, I would be okay resolving this one as "Won't
Fix" given there is a workaround and the bug is outside the product.
> cmake fails when Boost_INCLUDE_DIRS (and other variables passed to
> include_directories()) is empty
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3828
> URL: https://issues.apache.org/jira/browse/THRIFT-3828
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Reporter: Cody Schafer
> Assignee: James E. King, III
> Priority: Minor
> Attachments:
> 0001-cmake-avoid-use-of-both-quoted-paths-and-SYSTEM-with.patch
>
>
> This is due to the current quoting of those variables when passed to
> `include_directories()`. These variables may (and soon will, see below) be
> empty in the case where the include directory is a system include path that
> is implicitly included.
> I ran into this issue when trying to build thrift using gcc-6. gcc-6 doesn't
> work with includes that are part of the platform/system include path (see
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 for one mention). To
> resolve this, `FindBoost.cmake` will be adjusted to avoid adding those types
> of directories to Boost_INCLUDE_DIRS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
