GitHub user zhaakhi opened a pull request: https://github.com/apache/thrift/pull/1131
THRIFT-3886 PHP cross test client returns 0 even when failing PHP tests are mostly not asserting that the returned result is as expected, nor do they return an error for unknown protocols. Add more assertions in the style of the existing code, and check that the tested protocol is supported. This requires some fixes so tests will actually run for the accelerated binary protocol. Fixing the tests uncovers some brokenness in compact protocol and the extension, will submit fixes as separate patches. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhaakhi/thrift THRIFT-3886 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1131.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1131 ---- commit c3e80ca473a0e4e4be9c42d98ab58826fd96a919 Author: HÃ¥kon Hitland <hakon.hitl...@zedge.net> Date: 2016-11-17T15:18:03Z THRIFT-3886 PHP cross test client returns 0 even when failing PHP tests are mostly not asserting that the returned result is as expected, nor do they return an error for unknown protocols. Add more assertions in the style of the existing code, and check that the tested protocol is supported. This requires some fixes so tests will actually run for the accelerated binary protocol. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---