[ 
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793544#comment-15793544
 ] 

ASF GitHub Bot commented on THRIFT-2945:
----------------------------------------

Github user Jens-G commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1147#discussion_r94346945
  
    --- Diff: test/ThriftTest.thrift ---
    @@ -67,7 +67,7 @@ typedef i64 UserId
     struct Bonk
     {
       1: string message,
    -  2: i32 type
    +  2: i32 bonkType
     }
    --- End diff --
    
    Well, first, it is a keyword in Delphi too. Next, you cannot safely assume 
that anyone offering a Thrift API will test all languages implemented today if 
they work with the curent names you use in your IDL. And you cannot look into 
the future and foresee what language Apple or Google or whoever else comes 
around next week which may use "bonkType" as a keyword. So we have to deal with 
it. One way to do it is like the C# generator does it (look for 
`csharp_keywords`). The only bad thing about it is that we still have no common 
mechanism that is used by all generators. Today all generators more or less 
implement it their own way. I still have it on my list and some day I'll start 
working on it and finally consolidate that stuff.


> Implement support for Rust language
> -----------------------------------
>
>                 Key: THRIFT-2945
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2945
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Wish List
>            Reporter: Maksim Golov
>            Assignee: Jeremy Fitzhardinge
>
> Work on implementing support for Rust is in progress: 
> https://github.com/maximg/thrift by Simon GĂ©nier and myself.
> It will probably take quite some time to complete. Please keep us updated if 
> there are changes related to our work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to