Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1153#discussion_r94978623
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
ownEventBase_ = false;
}
- if (listenSocket_ >= 0) {
+ if (listenSocket_ >= 0 && listenSocket_ != THRIFT_INVALID_SOCKET) {
--- End diff --
Perhaps the only test needed is to see if the socket is not an invalid
socket? Is the >= 0 test necessary at this point?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
