[ 
https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830073#comment-15830073
 ] 

ASF GitHub Bot commented on THRIFT-3926:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1086
  
    As-is the patch would require string parsing to get the statusCode which is 
brittle.  I like the overall direction of handling unexpected status code with 
an exception; consider using a derived exception that encapsulates the 
information so one could call getStatusCode().


> There should be an error emitted when http status code is not 200 
> ------------------------------------------------------------------
>
>                 Key: THRIFT-3926
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3926
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>            Reporter: 李飛
>            Assignee: 李飛
>
> Sometimes the thrift servers is not ready to serve requests from the client. 
> The status code of response from the services is 40x or 50x. But the client 
> is never telled in this version of http_connections. There is no error at all 
> even when the response protocol is bad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to