[
https://issues.apache.org/jira/browse/THRIFT-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832054#comment-15832054
]
ASF GitHub Bot commented on THRIFT-3973:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1162
THRIFT-3973: Provide some tools to make it easier to build thrift C++ on
Windows
As a contributor and committer on the project with a focus on C++ and
CMake, I needed a way to build thrift C++ on windows with all the bells and
whistles. While cmake is a great tool for generating build environments on
different platforms, there is still an ecosystem of third party libraries
surrounding thrift that need to be acquired or built.
I was not certain if these files should end up in build/wincpp or in
contrib/wincpp. These files are not used in any of our CI builds. They simply
exist as a guide to make it easier to build thrift C++ on windows, including
how to build a redistributable thrift compiler for windows without any
dependencies, and how to generate Visual Studio projects for thrift on windows.
As part of this effort, the current C++ MSVC projects that are distributed
with the project will be removed once folks are happy with this toolset.
The README.md file contains information that can eventually be posted on:
https://thrift.apache.org/docs/install/windows
and the content there will be split into "older build information" and this
would be the current.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift story/THRIFT-3973-winbuild
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1162.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1162
----
commit d39c35a5ce8a79814b0294f110553c8097853c31
Author: James E. King, III <jim.k...@simplivity.com>
Date: 2017-01-20T16:15:25Z
THRIFT-3973: Provide some tools to make it easier to build thrift C++ on
Windows
----
> Remove MSVC C++ projects to improve maintainability; document building Thrift
> on Windows using CMake to generate project files
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3973
> URL: https://issues.apache.org/jira/browse/THRIFT-3973
> Project: Thrift
> Issue Type: Story
> Components: C++ - Compiler, C++ - Library
> Affects Versions: 0.10.0
> Environment: Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
>
> A class of issues has popped up where the project files checked into the
> project have become stale and/or the instructions for building on windows
> need to be updated.
> These issues are linked to this item. The purpose of this story is to
> eliminate these issues by getting rid of the project files checked into the
> project for windows (C++ specifically) and to update the web site
> documentation on how to build the thrift libraries for windows (native, not
> MinGW - those instructions will remain as-is).
> Acceptance Criteria:
> # MSVC project files for C++ are removed from the project.
> # Instructions for generating projects are provided on the web site. This
> must include support for:
> ## Compiler executable builds in debug and release form
> ## Static library builds in debug and release form (due to DLL export issues,
> windows builds do not support dynamic library generation today)
> ## Support for optional library support like zlib, libevent, boost, std
> (threads)
> ## Support for MSVC 2010 or later
> ## Support for CMake 3.6 or later
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
