Github user bgedik commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1080#discussion_r97712737
  
    --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
    @@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error) {
       }
     
       // sets a flag so that the loop exits on the next event
    --- End diff --
    
    I guess the comment is stale now. The loop now exits once the current 
iteration is complete.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to