Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98027723 --- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_platform_socket.h --- @@ -0,0 +1,120 @@ +/* --- End diff -- I tottally agree. It's a reimplementation of the library for c_glib to not mix things. But this can be seen as an upgrade. And start making room for an common library after merge. Don't you think?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---