[ https://issues.apache.org/jira/browse/THRIFT-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843503#comment-15843503 ]
ASF GitHub Bot commented on THRIFT-3854: ---------------------------------------- GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1164 THRIFT-3854 add a way in java to clear TFramedTransport read buffers I took https://github.com/apache/thrift/pull/1081 and applied changes to address the code comments. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift defect/THRIFT-3854 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1164.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1164 ---- commit dd8aa452d1651c827333056d5bd2b8fb422cdebe Author: James E. King, III <jim.k...@simplivity.com> Date: 2017-01-27T21:17:08Z THRIFT-3854 add a way in java to clear TFramedTransport read buffers ---- > allow users to clear read buffers > --------------------------------- > > Key: THRIFT-3854 > URL: https://issues.apache.org/jira/browse/THRIFT-3854 > Project: Thrift > Issue Type: Improvement > Components: Java - Library > Reporter: Chris Lockfort > Priority: Minor > Attachments: thrift-3854-clearable-read-buffers.patch > > > My use case (which I believe many others would share): > - I have a large number of Thrift connections in a connection pool > - Upon return of the used connection to the pool I would like to eagerly > clean up the read buffer because I know it will not be used again until the > connection is checked out and a new read puts a new buffer in its place. > - Eagerly clearing the read buffers of idle connections saves a considerable > amount of heap memory in my application, vs. having all of the idle > connections keep all of their read buffers allocated. > - Currently, it looks like someone thought about this and there is a > TMemoryInputTransport#clear() , but it isn't callable from people with a > TFramedTransport which uses a TMemoryInputTransport for its read buffer > (unless you count doing gross and brittle reflection magic). > I've included a patch, but I'm very flexible / open to opinions of how > someone more familiar to this project would want to implement a feature like > this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)