Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1172#discussion_r98554132
--- Diff: compiler/cpp/src/thrift/generate/t_cpp_generator.cc ---
@@ -1117,7 +1129,7 @@ void
t_cpp_generator::generate_struct_declaration(ofstream& out,
<< " &b);" << endl << endl;
}
- if (is_user_struct) {
+ if (is_user_struct && !has_custom_ostream(tstruct)) {
--- End diff --
This needs to change; on ostream declaration must be in the header even if
thrift does not emit an implementation for it so that a thrift class that emits
output code can contain a thrift class that does not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
