GitHub user jeking3 opened a pull request:

    https://github.com/apache/thrift/pull/1181

    THRIFT-4079 add missing use clauses for included thrift sources in 
generated perl modules

    Sadly the state of perl unit testing appears to be pretty sad... I don't 
see any tests for perl being run with "make check", nor are they run in the 
perl package maker (for cpan installs).  There are three test files but I'm not 
sure how they get run, if at all.  So there's no test for this.  I tested it on 
the example I submitted and it resolves the issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeking3/thrift THRIFT-4079

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1181
    
----
commit 7c8b5baa884cc9fe58ec8f10da528e4f7d0bcc75
Author: James E. King, III <jim.k...@simplivity.com>
Date:   2017-02-09T02:14:11Z

    THRIFT-4079 add missing use clauses for included thrift sources in 
generated perl modules

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to