[ 
https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859592#comment-15859592
 ] 

James E. King, III commented on THRIFT-3622:
--------------------------------------------

Well that was more fun that it needed to be.  <boost/move/unique_ptr.hpp> was 
introduced in boost 1.57 and before then an implementation exists in 
<boost/interprocess/smart_ptr/unique_ptr.hpp> but that implementation provides 
no default deleter.  Only one class (TFileTransport) uses the auto_ptr 
"release" concept.  I have auto_ptr removed and compatible with all boost 
versions locally, will submit a PR to get CI validation.

> Fix deprecated uses of std::auto_ptr
> ------------------------------------
>
>                 Key: THRIFT-3622
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3622
>             Project: Thrift
>          Issue Type: Task
>          Components: C++ - Library
>            Reporter: John Sirois
>            Assignee: James E. King, III
>
> We have some in lib/cpp, like so:
> {noformat}
> JSONProtoTest.cpp:35:13: warning: ‘template<class> class std::auto_ptr’ is 
> deprecated [-Wdeprecated-declarations]
>  static std::auto_ptr<OneOfEach> ooe;
>              ^
> In file included from /usr/include/c++/5.3.0/bits/locale_conv.h:41:0,
>                  from /usr/include/c++/5.3.0/locale:43,
>                  from /usr/include/c++/5.3.0/iomanip:43,
>                  from JSONProtoTest.cpp:22:
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to