[ 
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862911#comment-15862911
 ] 

Tony Przygienda commented on THRIFT-2945:
-----------------------------------------

fantastic work albeit it compltely ruined all my previous work & I need 
refactor now ;-) I pulled a branch since I suggest multiple changes to this 
work:

a) the namespace support could be significatnly better by allowing on top of 
the thrift file 

namespace * thriftmodule

that allows to put the thrift schemas into a submodule of a crate and use it 
that way which is very convenienent if you want to implement e.g. custom traits 
for the generated types ... I have the patch on 

https://github.com/przygienda/thrift-rust-thrift-include-and-custom-trait-support

already. It's not trivial since the namespace + get_program are interacting up 
to point things need be

::namespace::thriftmodule::type 

all works on the branch 

b)  suggest auto-derive Hash on the types for convienence 

c) will pull out the read_from_in_protocol and write_to_out_protocol as a trait 
implementation. Before there was a ThriftTyped which allowed to write generics 
for generated trait types. We need that again ;-) 

> Implement support for Rust language
> -----------------------------------
>
>                 Key: THRIFT-2945
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2945
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Rust - Compiler, Rust - Library
>            Reporter: Maksim Golov
>            Assignee: Allen George
>             Fix For: 0.11.0
>
>
> Work on implementing support for Rust is in progress: 
> https://github.com/maximg/thrift by Simon Génier and myself.
> It will probably take quite some time to complete. Please keep us updated if 
> there are changes related to our work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to