[ https://issues.apache.org/jira/browse/THRIFT-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866711#comment-15866711 ]
ASF GitHub Bot commented on THRIFT-2364: ---------------------------------------- GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1193 THRIFT-2364: use oasis to build thrift for ocaml You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift improvement/THRIFT-2364 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1193 ---- commit 14c81f1f4941b9c6b9d687988cc01cdbcf084e39 Author: James E. King, III <jim.k...@simplivity.com> Date: 2017-01-25T22:20:33Z THRIFT-2364: use oasis to build thrift for ocaml ---- > OCaml: Use Oasis exclusively for build process > ---------------------------------------------- > > Key: THRIFT-2364 > URL: https://issues.apache.org/jira/browse/THRIFT-2364 > Project: Thrift > Issue Type: Improvement > Components: Build Process, OCaml - Library > Environment: All environments > Reporter: Spiros Eliopoulos > Assignee: Spiros Eliopoulos > Priority: Minor > Attachments: THRIFT-2364.patch > > > The OCaml library currently contains custom makefiles, as well as an _oasis > configuration file that will generate a configuration script and Makefile. > The preferred method of the community for building OCaml libraries is to use > Oasis, so the other files should be dropped in favor of that. -- This message was sent by Atlassian JIRA (v6.3.15#6346)