Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1175#discussion_r101385004
  
    --- Diff: build/docker/debian/Dockerfile ---
    @@ -113,8 +113,8 @@ RUN apt-get update && apt-get install -y 
--no-install-recommends \
           neko-dev \
           libneko0
     
    -# Node.js dependencies - THRIFT-4064 says it must be >= 4.x
    -RUN curl -sL https://deb.nodesource.com/setup_4.x | bash -
    +# Node.js dependencies - THRIFT-4064 says it must be >= 0.12.0
    --- End diff --
    
    Wasn't the whole pont of this exercise to move up to node 4.x as a minimum 
supported version?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to