Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1197#discussion_r101907319
--- Diff: lib/py/src/transport/sslcompat.py ---
@@ -66,6 +66,14 @@ def legacy_validate_callback(cert, hostname):
--- End diff --
Is it to introduce backports.ssl as an optional dependency for older
Pythons ?
While it would make sense, there are some problematic details here.
I recommend doing it in a separate patch if you think it's worth it.
python2-secure is being listed in known_failures so this wouldn't affect
test results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
