Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1196#discussion_r101908414
  
    --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
    @@ -820,9 +821,11 @@ void TNonblockingServer::TConnection::setFlags(short 
eventFlags) {
      * Closes a connection
      */
     void TNonblockingServer::TConnection::close() {
    -  // Delete the registered libevent
    -  if (event_del(&event_) == -1) {
    -    GlobalOutput.perror("TConnection::close() event_del", 
THRIFT_GET_SOCKET_ERROR);
    +  if (eventFlags_) {
    +    if (event_del(&event_) == -1) {
    +      GlobalOutput("TConnection::close event_del");
    --- End diff --
    
    Sorry I copied this from another location and it must have been using 
GlobalOutput.  I will fix this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to