Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1197#discussion_r101909371
  
    --- Diff: test/tests.json ---
    @@ -606,5 +606,23 @@
           "compact"
         ],
         "workdir": "rs/bin"
    +  },
    +  {
    +    "name": "secure",
    +    "client": {
    +      "command": [
    +        "test_secure.bash"
    +      ]
    +    },
    +    "transports": [
    +      "buffered"
    +    ],
    +    "sockets": [
    +      "ip-ssl"
    +    ],
    +    "protocols": [
    +      "binary"
    +    ],
    +    "workdir": "secure"
    --- End diff --
    
    Simply moving the same JSON entry (with relative file path adjustment) 
might get this included to `make crossfeature`.
    In that case, known_failure file is also in `features/known_...`.
    
    Otherwise we can leave it as is and plan to relocate later.
    I guess I'll need to put some information to `test/README.md` or create 
`test/features/README.md`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to