Github user gadLinux commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1200#discussion_r102328202
--- Diff: lib/java/test/org/apache/thrift/test/TestServer.java ---
@@ -190,7 +193,9 @@ public static void main(String [] args) {
if (protocol_type.equals("binary")) {
} else if (protocol_type.equals("compact")) {
} else if (protocol_type.equals("json")) {
- } else if (protocol_type.equals("multiplexed")) {
+ } else if (protocol_type.equals("multi")) {
--- End diff --
I don't know much about tests. But you can get crazy here if there's a lot
of procotols.
I suggest what I did. Adding a prefix and sufix. The prefix can be matched
against multiplexed (multi) the suffix is the name of the protocol of the
underlaying implementation.
This convention doesn't add anything to the code. And makes you be ready
for the multiplexed whether a new protocol is added with no effort.
Convention over configuration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
