[ https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898401#comment-15898401 ]
James E. King, III commented on THRIFT-4029: -------------------------------------------- This build passed CI however I'm not a python packaging SME. Could someone tell me if the pull request resolves the issue and should be merged? > Accelerated protocols do not build from thrift-py 0.10.0 on PyPI > ---------------------------------------------------------------- > > Key: THRIFT-4029 > URL: https://issues.apache.org/jira/browse/THRIFT-4029 > Project: Thrift > Issue Type: Bug > Components: Python - Library > Affects Versions: 0.10.0 > Reporter: Chandler May > Assignee: Jake Farrell > > The thrift 0.10.0 distribution on PyPI does not include extension headers and > a C++ (template) file, preventing the accelerated protocols from being built. > {{pip install}} reports a brief error: > {code} > Running thrift-0.10.0/setup.py -q bdist_egg --dist-dir > /tmp/easy_install-bVU8VN/thrift-0.10.0/egg-dist-tmp-ghJzGL > cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for > C/ObjC but not for C++ > src/ext/module.cpp:21:19: fatal error: types.h: No such file or directory > #include "types.h" > ^ > compilation terminated. > () > ******************************************************************************** > An error occurred while trying to compile with the C extension enabled > Attempting to build without the extension now > ******************************************************************************** > () > {code} > The list of files that is not included in the distribution is as follows. In > addition to the headers and source file mentioned above, there's a Windows > compatibility header missing and a couple of test files missing. It looks > like there was a file extension filter (accidentally) applied to the C++ > files at least: > {code} > src/ext/binary.h > src/ext/compact.h > src/ext/endian.h > src/ext/protocol.h > src/ext/protocol.tcc > src/ext/types.h > compat/win32/stdint.h > test/_import_local_thrift.py > test/thrift_json.py > {code} > [~jfarrell] were you who made the release? Is it possible to hotfix? My > team has been waiting on the release of the accelerated compact protocol for > a while, this discovery is saddening for us. -- This message was sent by Atlassian JIRA (v6.3.15#6346)