Hi Jim,

I’ve never read a formal rule about it in the ASF docs, but that could also be 
because I just did not look at the right place. On the other hand it is a 
common best practice, to avoid modifying pushed commits later on. It can lead 
to issues when people update their working copies and it may create all kinds 
of confusion. So I would not recommend it in general, and in particular not 
with master branches. What one does with his private repo on Github is another 
story.

In that particular case, I’d just leave it as it is. Ok, it’s not nice and not 
perfect, but also not worth any potential or real trouble at all. Personal 
opinion, of course.

Have fun,
JensG





From: Jim King
Sent: Thursday, March 23, 2017 1:35 AM
To: [email protected]
Subject: git commit --amend

I attributed a fix to C++ when it is for Java in the check-in comments (Client: 
).
Can I do a “git commit –amend” and “git push –force” on master?  Is that 
acceptable (the force push part)?

[hpesimplivitytogether]
James E. King, III
HPE SimpliVity
8 Technology Drive, 2nd Floor
Westborough, MA 01581-1756
Ph: 855-SVT-INFO



________________________________
PRIVACY STATEMENT:
This message is a PRIVATE communication. This message and all attachments are a 
private communication sent by SimpliVity and are considered to be confidential 
or protected by privilege. If you are not the intended recipient, you are 
hereby notified that any disclosure, copying, distribution or use of the 
information contained in or attached to this message is strictly prohibited. 
Please notify the sender of the delivery error by replying to this message, and 
then delete it from your system.
For more information please visit http://www.simplivity.com
________________________________

Reply via email to